Commit 8686f337 authored by Tobias Herzog's avatar Tobias Herzog Committed by Greg Kroah-Hartman

cdc-acm: do not reset notification buffer index upon urb unlinking

commit dae3ddba upstream.

Resetting the write index of the notification buffer on urb unlink (e.g.
closing a cdc-acm device from userspace) may lead to wrong interpretation
of further received notifications, in case the index is not 0 when urb
unlink happens (i.e. when parts of a notification already have been
transferred). On the device side there is no "reset" of the notification
transimission and thus we would get out of sync with the device.
Signed-off-by: default avatarTobias Herzog <t-herzog@gmx.de>
Acked-by: default avatarOliver Neukum <oneukum@suse.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f0e3b74a
...@@ -367,7 +367,6 @@ static void acm_ctrl_irq(struct urb *urb) ...@@ -367,7 +367,6 @@ static void acm_ctrl_irq(struct urb *urb)
case -ENOENT: case -ENOENT:
case -ESHUTDOWN: case -ESHUTDOWN:
/* this urb is terminated, clean up */ /* this urb is terminated, clean up */
acm->nb_index = 0;
dev_dbg(&acm->control->dev, dev_dbg(&acm->control->dev,
"%s - urb shutting down with status: %d\n", "%s - urb shutting down with status: %d\n",
__func__, status); __func__, status);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment