Commit 86a2f415 authored by Phil Sutter's avatar Phil Sutter Committed by David S. Miller

usbnet: sanitise overlong driver information strings

As seen on smsc75xx, driver_info->description being longer than 32
characters messes up 'ethtool -i' output.
Signed-off-by: default avatarPhil Sutter <phil.sutter@viprinet.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0b3f0e7a
...@@ -876,9 +876,9 @@ void usbnet_get_drvinfo (struct net_device *net, struct ethtool_drvinfo *info) ...@@ -876,9 +876,9 @@ void usbnet_get_drvinfo (struct net_device *net, struct ethtool_drvinfo *info)
{ {
struct usbnet *dev = netdev_priv(net); struct usbnet *dev = netdev_priv(net);
strncpy (info->driver, dev->driver_name, sizeof info->driver); strlcpy (info->driver, dev->driver_name, sizeof info->driver);
strncpy (info->version, DRIVER_VERSION, sizeof info->version); strlcpy (info->version, DRIVER_VERSION, sizeof info->version);
strncpy (info->fw_version, dev->driver_info->description, strlcpy (info->fw_version, dev->driver_info->description,
sizeof info->fw_version); sizeof info->fw_version);
usb_make_path (dev->udev, info->bus_info, sizeof info->bus_info); usb_make_path (dev->udev, info->bus_info, sizeof info->bus_info);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment