Commit 86a462bc authored by Paulo Zanoni's avatar Paulo Zanoni

drm/i915/gen9: fail the modeset instead of WARNing on unsupported config

Now that this code is part of the compute stage we can return -EINVAL
to prevent the modeset instead of giving a WARN and trying anyway.

v2:
 - Fix typo (Paul Menzel).
 - Add MISSING_CASE() (Ville, Maarten).
Reported-by: default avatarLyude <cpaul@redhat.com>
Reviewed-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: default avatarPaulo Zanoni <paulo.r.zanoni@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1474578035-424-10-git-send-email-paulo.r.zanoni@intel.com
parent f1db3eaf
...@@ -3580,11 +3580,12 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, ...@@ -3580,11 +3580,12 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv,
case 2: case 2:
y_min_scanlines = 8; y_min_scanlines = 8;
break; break;
default:
WARN(1, "Unsupported pixel depth for rotation");
case 4: case 4:
y_min_scanlines = 4; y_min_scanlines = 4;
break; break;
default:
MISSING_CASE(cpp);
return -EINVAL;
} }
} else { } else {
y_min_scanlines = 4; y_min_scanlines = 4;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment