Commit 86da8be3 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Lee Jones

mfd: intel_soc_pmic_bxtwc: Use sysfs_emit() instead of sprintf()

sysfs_emit() is preferred over sprintf() when formatting the value to be
returned to user space in show() functions, because it knows about sysfs
buffer specifics and has sanity checks.
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220628221747.33956-9-andriy.shevchenko@linux.intel.com
parent f801556a
...@@ -334,7 +334,7 @@ static unsigned long bxtwc_reg_addr; ...@@ -334,7 +334,7 @@ static unsigned long bxtwc_reg_addr;
static ssize_t addr_show(struct device *dev, static ssize_t addr_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
return sprintf(buf, "0x%lx\n", bxtwc_reg_addr); return sysfs_emit(buf, "0x%lx\n", bxtwc_reg_addr);
} }
static ssize_t addr_store(struct device *dev, static ssize_t addr_store(struct device *dev,
...@@ -362,7 +362,7 @@ static ssize_t val_show(struct device *dev, ...@@ -362,7 +362,7 @@ static ssize_t val_show(struct device *dev,
return ret; return ret;
} }
return sprintf(buf, "0x%02x\n", val); return sysfs_emit(buf, "0x%02x\n", val);
} }
static ssize_t val_store(struct device *dev, static ssize_t val_store(struct device *dev,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment