Commit 86f1ea9d authored by YueHaibing's avatar YueHaibing Committed by Kalle Valo

wlcore: use DEVICE_ATTR_<RW|RO> macro

Use DEVICE_ATTR_<RW|RO> helper instead of plain DEVICE_ATTR,
which makes the code a bit shorter and easier to read.
Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210523033538.25568-1-yuehaibing@huawei.com
parent 080f9c10
...@@ -12,9 +12,9 @@ ...@@ -12,9 +12,9 @@
#include "debug.h" #include "debug.h"
#include "sysfs.h" #include "sysfs.h"
static ssize_t wl1271_sysfs_show_bt_coex_state(struct device *dev, static ssize_t bt_coex_state_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct wl1271 *wl = dev_get_drvdata(dev); struct wl1271 *wl = dev_get_drvdata(dev);
ssize_t len; ssize_t len;
...@@ -30,9 +30,9 @@ static ssize_t wl1271_sysfs_show_bt_coex_state(struct device *dev, ...@@ -30,9 +30,9 @@ static ssize_t wl1271_sysfs_show_bt_coex_state(struct device *dev,
} }
static ssize_t wl1271_sysfs_store_bt_coex_state(struct device *dev, static ssize_t bt_coex_state_store(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
const char *buf, size_t count) const char *buf, size_t count)
{ {
struct wl1271 *wl = dev_get_drvdata(dev); struct wl1271 *wl = dev_get_drvdata(dev);
unsigned long res; unsigned long res;
...@@ -71,13 +71,11 @@ static ssize_t wl1271_sysfs_store_bt_coex_state(struct device *dev, ...@@ -71,13 +71,11 @@ static ssize_t wl1271_sysfs_store_bt_coex_state(struct device *dev,
return count; return count;
} }
static DEVICE_ATTR(bt_coex_state, 0644, static DEVICE_ATTR_RW(bt_coex_state);
wl1271_sysfs_show_bt_coex_state,
wl1271_sysfs_store_bt_coex_state);
static ssize_t wl1271_sysfs_show_hw_pg_ver(struct device *dev, static ssize_t hw_pg_ver_show(struct device *dev,
struct device_attribute *attr, struct device_attribute *attr,
char *buf) char *buf)
{ {
struct wl1271 *wl = dev_get_drvdata(dev); struct wl1271 *wl = dev_get_drvdata(dev);
ssize_t len; ssize_t len;
...@@ -94,7 +92,7 @@ static ssize_t wl1271_sysfs_show_hw_pg_ver(struct device *dev, ...@@ -94,7 +92,7 @@ static ssize_t wl1271_sysfs_show_hw_pg_ver(struct device *dev,
return len; return len;
} }
static DEVICE_ATTR(hw_pg_ver, 0444, wl1271_sysfs_show_hw_pg_ver, NULL); static DEVICE_ATTR_RO(hw_pg_ver);
static ssize_t wl1271_sysfs_read_fwlog(struct file *filp, struct kobject *kobj, static ssize_t wl1271_sysfs_read_fwlog(struct file *filp, struct kobject *kobj,
struct bin_attribute *bin_attr, struct bin_attribute *bin_attr,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment