Commit 87009d86 authored by Dmitry Monakhov's avatar Dmitry Monakhov Committed by Theodore Ts'o

ext4: do not try to grab the s_umount semaphore in ext4_quota_off

It's not needed to sync the filesystem, and it fixes a lock_dep complaint.
Signed-off-by: default avatarDmitry Monakhov <dmonakhov@gmail.com>
Signed-off-by: default avatar"Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
parent 83668e71
...@@ -4570,12 +4570,10 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id, ...@@ -4570,12 +4570,10 @@ static int ext4_quota_on(struct super_block *sb, int type, int format_id,
static int ext4_quota_off(struct super_block *sb, int type) static int ext4_quota_off(struct super_block *sb, int type)
{ {
/* Force all delayed allocation blocks to be allocated */ /* Force all delayed allocation blocks to be allocated.
if (test_opt(sb, DELALLOC)) { * Caller already holds s_umount sem */
down_read(&sb->s_umount); if (test_opt(sb, DELALLOC))
sync_filesystem(sb); sync_filesystem(sb);
up_read(&sb->s_umount);
}
return dquot_quota_off(sb, type); return dquot_quota_off(sb, type);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment