Commit 871fc058 authored by Martin Svec's avatar Martin Svec Committed by Jiri Slaby

Target/sbc: Initialize COMPARE_AND_WRITE write_sg scatterlist

commit a1e1774c upstream.

When compiled with CONFIG_DEBUG_SG set, uninitialized SGL leads
to BUG() in compare_and_write_callback().
Signed-off-by: default avatarMartin Svec <martin.svec@zoner.cz>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
parent 4c575603
...@@ -409,13 +409,14 @@ static sense_reason_t compare_and_write_callback(struct se_cmd *cmd) ...@@ -409,13 +409,14 @@ static sense_reason_t compare_and_write_callback(struct se_cmd *cmd)
goto out; goto out;
} }
write_sg = kzalloc(sizeof(struct scatterlist) * cmd->t_data_nents, write_sg = kmalloc(sizeof(struct scatterlist) * cmd->t_data_nents,
GFP_KERNEL); GFP_KERNEL);
if (!write_sg) { if (!write_sg) {
pr_err("Unable to allocate compare_and_write sg\n"); pr_err("Unable to allocate compare_and_write sg\n");
ret = TCM_OUT_OF_RESOURCES; ret = TCM_OUT_OF_RESOURCES;
goto out; goto out;
} }
sg_init_table(write_sg, cmd->t_data_nents);
/* /*
* Setup verify and write data payloads from total NumberLBAs. * Setup verify and write data payloads from total NumberLBAs.
*/ */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment