Commit 878336c3 authored by Stefan Wolz's avatar Stefan Wolz Committed by Greg Kroah-Hartman

sm750fb/sm750_hw.c: fixed comments

Fixed multiline comments to meet style standards,
fixed typos and split comment lines over 80 characters.
Signed-off-by: default avatarStefan Wolz <wolzstefan@web.de>
Signed-off-by: default avatarChristian Halder <christian.halder@fau.de>
Signed-off-by: default avatarSebastian Handwerker <sebastian.handwerker@posteo.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1f24c865
...@@ -35,17 +35,17 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) ...@@ -35,17 +35,17 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
pr_info("mmio phyAddr = %lx\n", sm750_dev->vidreg_start); pr_info("mmio phyAddr = %lx\n", sm750_dev->vidreg_start);
/* reserve the vidreg space of smi adaptor /* reserve the vidreg space of smi adaptor
* if you do this, u need to add release region code * if you do this, you need to add release region code
* in lynxfb_remove, or memory will not be mapped again * in lynxfb_remove, or memory will not be mapped again
* successfully * successfully
* */ */
ret = pci_request_region(pdev, 1, "sm750fb"); ret = pci_request_region(pdev, 1, "sm750fb");
if (ret) { if (ret) {
pr_err("Can not request PCI regions.\n"); pr_err("Can not request PCI regions.\n");
goto exit; goto exit;
} }
/* now map mmio and vidmem*/ /* now map mmio and vidmem */
sm750_dev->pvReg = ioremap_nocache(sm750_dev->vidreg_start, sm750_dev->pvReg = ioremap_nocache(sm750_dev->vidreg_start,
sm750_dev->vidreg_size); sm750_dev->vidreg_size);
if (!sm750_dev->pvReg) { if (!sm750_dev->pvReg) {
...@@ -63,10 +63,10 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) ...@@ -63,10 +63,10 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
sm750_dev->vidmem_start = pci_resource_start(pdev, 0); sm750_dev->vidmem_start = pci_resource_start(pdev, 0);
/* don't use pdev_resource[x].end - resource[x].start to /* don't use pdev_resource[x].end - resource[x].start to
* calculate the resource size,its only the maximum available * calculate the resource size, it's only the maximum available
* size but not the actual size,use * size but not the actual size, using
* @ddk750_getVMSize function can be safe. * @ddk750_getVMSize function can be safe.
* */ */
sm750_dev->vidmem_size = ddk750_getVMSize(); sm750_dev->vidmem_size = ddk750_getVMSize();
pr_info("video memory phyAddr = %lx, size = %u bytes\n", pr_info("video memory phyAddr = %lx, size = %u bytes\n",
sm750_dev->vidmem_start, sm750_dev->vidmem_size); sm750_dev->vidmem_start, sm750_dev->vidmem_size);
...@@ -101,7 +101,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) ...@@ -101,7 +101,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
parm->master_clk = parm->chip_clk / 3; parm->master_clk = parm->chip_clk / 3;
ddk750_initHw((initchip_param_t *)&sm750_dev->initParm); ddk750_initHw((initchip_param_t *)&sm750_dev->initParm);
/* for sm718,open pci burst */ /* for sm718, open pci burst */
if (sm750_dev->devid == 0x718) { if (sm750_dev->devid == 0x718) {
POKE32(SYSTEM_CTRL, POKE32(SYSTEM_CTRL,
PEEK32(SYSTEM_CTRL) | SYSTEM_CTRL_PCI_BURST); PEEK32(SYSTEM_CTRL) | SYSTEM_CTRL_PCI_BURST);
...@@ -109,7 +109,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) ...@@ -109,7 +109,7 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
if (getChipType() != SM750LE) { if (getChipType() != SM750LE) {
unsigned int val; unsigned int val;
/* does user need CRT ?*/ /* does user need CRT? */
if (sm750_dev->nocrt) { if (sm750_dev->nocrt) {
POKE32(MISC_CTRL, POKE32(MISC_CTRL,
PEEK32(MISC_CTRL) | MISC_CTRL_DAC_POWER_OFF); PEEK32(MISC_CTRL) | MISC_CTRL_DAC_POWER_OFF);
...@@ -141,19 +141,21 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev) ...@@ -141,19 +141,21 @@ int hw_sm750_inithw(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
} }
POKE32(PANEL_DISPLAY_CTRL, val); POKE32(PANEL_DISPLAY_CTRL, val);
} else { } else {
/* for 750LE ,no DVI chip initialization makes Monitor no signal */ /* for 750LE, no DVI chip initialization
/* Set up GPIO for software I2C to program DVI chip in the * makes Monitor no signal
Xilinx SP605 board, in order to have video signal. *
* Set up GPIO for software I2C to program DVI chip in the
* Xilinx SP605 board, in order to have video signal.
*/ */
sm750_sw_i2c_init(0, 1); sm750_sw_i2c_init(0, 1);
/* Customer may NOT use CH7301 DVI chip, which has to be /* Customer may NOT use CH7301 DVI chip, which has to be
initialized differently. * initialized differently.
*/ */
if (sm750_sw_i2c_read_reg(0xec, 0x4a) == 0x95) { if (sm750_sw_i2c_read_reg(0xec, 0x4a) == 0x95) {
/* The following register values for CH7301 are from /* The following register values for CH7301 are from
Chrontel app note and our experiment. * Chrontel app note and our experiment.
*/ */
pr_info("yes,CH7301 DVI chip found\n"); pr_info("yes,CH7301 DVI chip found\n");
sm750_sw_i2c_write_reg(0xec, 0x1d, 0x16); sm750_sw_i2c_write_reg(0xec, 0x1d, 0x16);
sm750_sw_i2c_write_reg(0xec, 0x21, 0x9); sm750_sw_i2c_write_reg(0xec, 0x21, 0x9);
...@@ -198,7 +200,7 @@ int hw_sm750_output_setMode(struct lynxfb_output *output, ...@@ -198,7 +200,7 @@ int hw_sm750_output_setMode(struct lynxfb_output *output,
} }
ddk750_setLogicalDispOut(dispSet); ddk750_setLogicalDispOut(dispSet);
} else { } else {
/* just open DISPLAY_CONTROL_750LE register bit 3:0*/ /* just open DISPLAY_CONTROL_750LE register bit 3:0 */
u32 reg; u32 reg;
reg = PEEK32(DISPLAY_CONTROL_750LE); reg = PEEK32(DISPLAY_CONTROL_750LE);
...@@ -234,9 +236,7 @@ int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo * ...@@ -234,9 +236,7 @@ int hw_sm750_crtc_checkMode(struct lynxfb_crtc *crtc, struct fb_var_screeninfo *
return 0; return 0;
} }
/* /* set the controller's mode for @crtc charged with @var and @fix parameters */
set the controller's mode for @crtc charged with @var and @fix parameters
*/
int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
struct fb_var_screeninfo *var, struct fb_var_screeninfo *var,
struct fb_fix_screeninfo *fix) struct fb_fix_screeninfo *fix)
...@@ -300,12 +300,14 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, ...@@ -300,12 +300,14 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
} }
if (crtc->channel != sm750_secondary) { if (crtc->channel != sm750_secondary) {
/* set pitch, offset ,width,start address ,etc... */ /* set pitch, offset, width, start address, etc... */
POKE32(PANEL_FB_ADDRESS, POKE32(PANEL_FB_ADDRESS,
crtc->oScreen & PANEL_FB_ADDRESS_ADDRESS_MASK); crtc->oScreen & PANEL_FB_ADDRESS_ADDRESS_MASK);
reg = var->xres * (var->bits_per_pixel >> 3); reg = var->xres * (var->bits_per_pixel >> 3);
/* crtc->channel is not equal to par->index on numeric,be aware of that */ /* crtc->channel is not equal to par->index on numeric,
* be aware of that
*/
reg = ALIGN(reg, crtc->line_pad); reg = ALIGN(reg, crtc->line_pad);
reg = (reg << PANEL_FB_WIDTH_WIDTH_SHIFT) & reg = (reg << PANEL_FB_WIDTH_WIDTH_SHIFT) &
PANEL_FB_WIDTH_WIDTH_MASK; PANEL_FB_WIDTH_WIDTH_MASK;
...@@ -337,7 +339,9 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, ...@@ -337,7 +339,9 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc,
/* not implemented now */ /* not implemented now */
POKE32(CRT_FB_ADDRESS, crtc->oScreen); POKE32(CRT_FB_ADDRESS, crtc->oScreen);
reg = var->xres * (var->bits_per_pixel >> 3); reg = var->xres * (var->bits_per_pixel >> 3);
/* crtc->channel is not equal to par->index on numeric,be aware of that */ /* crtc->channel is not equal to par->index on numeric,
* be aware of that
*/
reg = ALIGN(reg, crtc->line_pad) << CRT_FB_WIDTH_WIDTH_SHIFT; reg = ALIGN(reg, crtc->line_pad) << CRT_FB_WIDTH_WIDTH_SHIFT;
reg &= CRT_FB_WIDTH_WIDTH_MASK; reg &= CRT_FB_WIDTH_WIDTH_MASK;
reg |= (fix->line_length & CRT_FB_WIDTH_OFFSET_MASK); reg |= (fix->line_length & CRT_FB_WIDTH_OFFSET_MASK);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment