Commit 8788c6c2 authored by Atul Kumar Pant's avatar Atul Kumar Pant Committed by Ingo Molnar

locking/debug: Fix debugfs API return value checks to use IS_ERR()

Update the checking of return values from debugfs_create_file()
and debugfs_create_dir() to use IS_ERR().
Signed-off-by: default avatarAtul Kumar Pant <atulpant.linux@gmail.com>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Acked-by: default avatarWaiman Long <longman@redhat.com>
Link: https://lore.kernel.org/r/20230807121834.7438-1-atulpant.linux@gmail.com
parent cfa92b6d
...@@ -146,7 +146,7 @@ static int __init init_lockevent_counts(void) ...@@ -146,7 +146,7 @@ static int __init init_lockevent_counts(void)
struct dentry *d_counts = debugfs_create_dir(LOCK_EVENTS_DIR, NULL); struct dentry *d_counts = debugfs_create_dir(LOCK_EVENTS_DIR, NULL);
int i; int i;
if (!d_counts) if (IS_ERR(d_counts))
goto out; goto out;
/* /*
...@@ -159,14 +159,14 @@ static int __init init_lockevent_counts(void) ...@@ -159,14 +159,14 @@ static int __init init_lockevent_counts(void)
for (i = 0; i < lockevent_num; i++) { for (i = 0; i < lockevent_num; i++) {
if (skip_lockevent(lockevent_names[i])) if (skip_lockevent(lockevent_names[i]))
continue; continue;
if (!debugfs_create_file(lockevent_names[i], 0400, d_counts, if (IS_ERR(debugfs_create_file(lockevent_names[i], 0400, d_counts,
(void *)(long)i, &fops_lockevent)) (void *)(long)i, &fops_lockevent)))
goto fail_undo; goto fail_undo;
} }
if (!debugfs_create_file(lockevent_names[LOCKEVENT_reset_cnts], 0200, if (IS_ERR(debugfs_create_file(lockevent_names[LOCKEVENT_reset_cnts], 0200,
d_counts, (void *)(long)LOCKEVENT_reset_cnts, d_counts, (void *)(long)LOCKEVENT_reset_cnts,
&fops_lockevent)) &fops_lockevent)))
goto fail_undo; goto fail_undo;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment