Commit 8853a2f6 authored by Yurii Pavlovskyi's avatar Yurii Pavlovskyi Committed by Andy Shevchenko

platform/x86: asus-wmi: Fix preserving keyboard backlight intensity on load

The error code and return value are mixed up. The intensity is always set
to 0 on load as kbd_led_read returns either 0 or negative value. To
reproduce set backlight to maximum, reload driver and try to increase it
using keyboard hotkey, the intensity will drop as a result. Correct the
implementation.
Signed-off-by: default avatarYurii Pavlovskyi <yurii.pavlovskyi@gmail.com>
Reviewed-by: default avatarDaniel Drake <drake@endlessm.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent cd10ee00
...@@ -595,8 +595,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus) ...@@ -595,8 +595,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
goto error; goto error;
} }
led_val = kbd_led_read(asus, NULL, NULL); if (!kbd_led_read(asus, &led_val, NULL)) {
if (led_val >= 0) {
asus->kbd_led_wk = led_val; asus->kbd_led_wk = led_val;
asus->kbd_led.name = "asus::kbd_backlight"; asus->kbd_led.name = "asus::kbd_backlight";
asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED; asus->kbd_led.flags = LED_BRIGHT_HW_CHANGED;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment