Commit 889cda36 authored by Kevin Barnett's avatar Kevin Barnett Committed by Martin K. Petersen

scsi: smartpqi: Remove NULL pointer check

Remove an unnecessary check for a NULL pointer.  This unnecessary check was
flagged by Coverity.
Reviewed-by: default avatarScott Benesh <scott.benesh@microchip.com>
Reviewed-by: default avatarScott Teel <scott.teel@microchip.com>
Reviewed-by: default avatarMike McGowen <mike.mcgowen@microchip.com>
Signed-off-by: default avatarKevin Barnett <kevin.barnett@microchip.com>
Signed-off-by: default avatarDon Brace <don.brace@microchip.com>
Link: https://lore.kernel.org/r/20230428153712.297638-4-don.brace@microchip.comSigned-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent fe0375d4
......@@ -92,25 +92,23 @@ static int pqi_sas_port_add_rphy(struct pqi_sas_port *pqi_sas_port,
identify = &rphy->identify;
identify->sas_address = pqi_sas_port->sas_address;
identify->phy_identifier = pqi_sas_port->device->phy_id;
identify->initiator_port_protocols = SAS_PROTOCOL_ALL;
identify->target_port_protocols = SAS_PROTOCOL_STP;
if (pqi_sas_port->device) {
identify->phy_identifier = pqi_sas_port->device->phy_id;
switch (pqi_sas_port->device->device_type) {
case SA_DEVICE_TYPE_SAS:
case SA_DEVICE_TYPE_SES:
case SA_DEVICE_TYPE_NVME:
identify->target_port_protocols = SAS_PROTOCOL_SSP;
break;
case SA_DEVICE_TYPE_EXPANDER_SMP:
identify->target_port_protocols = SAS_PROTOCOL_SMP;
break;
case SA_DEVICE_TYPE_SATA:
default:
break;
}
switch (pqi_sas_port->device->device_type) {
case SA_DEVICE_TYPE_SAS:
case SA_DEVICE_TYPE_SES:
case SA_DEVICE_TYPE_NVME:
identify->target_port_protocols = SAS_PROTOCOL_SSP;
break;
case SA_DEVICE_TYPE_EXPANDER_SMP:
identify->target_port_protocols = SAS_PROTOCOL_SMP;
break;
case SA_DEVICE_TYPE_SATA:
default:
break;
}
return sas_rphy_add(rphy);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment