Commit 88b7210c authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Jens Axboe

block: iolatency: avoid 64-bit division

On 32-bit architectures, dividing a 64-bit number needs to use the
do_div() function or something like it to avoid a link failure:

block/blk-iolatency.o: In function `iolatency_prfill_limit':
blk-iolatency.c:(.text+0x8cc): undefined reference to `__aeabi_uldivmod'

Using div_u64() gives us the best output and avoids the need for an
explicit cast.

Fixes: d7067512 ("block: introduce blk-iolatency io controller")
Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 3993e501
...@@ -798,8 +798,7 @@ static u64 iolatency_prfill_limit(struct seq_file *sf, ...@@ -798,8 +798,7 @@ static u64 iolatency_prfill_limit(struct seq_file *sf,
if (!dname || !iolat->min_lat_nsec) if (!dname || !iolat->min_lat_nsec)
return 0; return 0;
seq_printf(sf, "%s target=%llu\n", seq_printf(sf, "%s target=%llu\n",
dname, dname, div_u64(iolat->min_lat_nsec, NSEC_PER_USEC));
(unsigned long long)iolat->min_lat_nsec / NSEC_PER_USEC);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment