Commit 88e7594a authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller

phonet: use call_rcu for phonet device free

Use call_rcu rather than synchronize_rcu.
Signed-off-by: default avatarJiri Pirko <jpirko@redhat.com>
Acked-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent bb69ae04
...@@ -34,6 +34,7 @@ struct phonet_device { ...@@ -34,6 +34,7 @@ struct phonet_device {
struct list_head list; struct list_head list;
struct net_device *netdev; struct net_device *netdev;
DECLARE_BITMAP(addrs, 64); DECLARE_BITMAP(addrs, 64);
struct rcu_head rcu;
}; };
int phonet_device_init(void); int phonet_device_init(void);
......
...@@ -162,6 +162,14 @@ int phonet_address_add(struct net_device *dev, u8 addr) ...@@ -162,6 +162,14 @@ int phonet_address_add(struct net_device *dev, u8 addr)
return err; return err;
} }
static void phonet_device_rcu_free(struct rcu_head *head)
{
struct phonet_device *pnd;
pnd = container_of(head, struct phonet_device, rcu);
kfree(pnd);
}
int phonet_address_del(struct net_device *dev, u8 addr) int phonet_address_del(struct net_device *dev, u8 addr)
{ {
struct phonet_device_list *pndevs = phonet_device_list(dev_net(dev)); struct phonet_device_list *pndevs = phonet_device_list(dev_net(dev));
...@@ -179,10 +187,9 @@ int phonet_address_del(struct net_device *dev, u8 addr) ...@@ -179,10 +187,9 @@ int phonet_address_del(struct net_device *dev, u8 addr)
pnd = NULL; pnd = NULL;
mutex_unlock(&pndevs->lock); mutex_unlock(&pndevs->lock);
if (pnd) { if (pnd)
synchronize_rcu(); call_rcu(&pnd->rcu, phonet_device_rcu_free);
kfree(pnd);
}
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment