Commit 88f878e5 authored by Mikulas Patocka's avatar Mikulas Patocka Committed by Mike Snitzer

dm bufio: clean up rbtree block ordering

dm-bufio uses unnatural ordering in the rb-tree - blocks with smaller
numbers were put to the right node and blocks with bigger numbers were
put to the left node.

Reverse that logic so that it's natural.
Signed-off-by: default avatarMikulas Patocka <mpatocka@redhat.com>
Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
parent 40e9c5ac
...@@ -256,7 +256,7 @@ static struct dm_buffer *__find(struct dm_bufio_client *c, sector_t block) ...@@ -256,7 +256,7 @@ static struct dm_buffer *__find(struct dm_bufio_client *c, sector_t block)
if (b->block == block) if (b->block == block)
return b; return b;
n = (b->block < block) ? n->rb_left : n->rb_right; n = block < b->block ? n->rb_left : n->rb_right;
} }
return NULL; return NULL;
...@@ -276,8 +276,8 @@ static void __insert(struct dm_bufio_client *c, struct dm_buffer *b) ...@@ -276,8 +276,8 @@ static void __insert(struct dm_bufio_client *c, struct dm_buffer *b)
} }
parent = *new; parent = *new;
new = (found->block < b->block) ? new = b->block < found->block ?
&((*new)->rb_left) : &((*new)->rb_right); &found->node.rb_left : &found->node.rb_right;
} }
rb_link_node(&b->node, parent, new); rb_link_node(&b->node, parent, new);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment