Commit 892cb6dc authored by Laxman Dewangan's avatar Laxman Dewangan Committed by Greg Kroah-Hartman

staging: iio: light: isl29028: fix correct mask value

The mask value in the read_raw/write_raw is absolute
value, not the bit position value.
Fixing this in the implemented function to check value,
not with the bit position value.
Signed-off-by: default avatarLaxman Dewangan <ldewangan@nvidia.com>
Acked-by: default avatarJonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c5714b5a
......@@ -272,7 +272,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev,
mutex_lock(&chip->lock);
switch (chan->type) {
case IIO_PROXIMITY:
if (mask != IIO_CHAN_INFO_SAMP_FREQ_SEPARATE_BIT) {
if (mask != IIO_CHAN_INFO_SAMP_FREQ) {
dev_err(chip->dev,
"proximity: mask value 0x%08lx not supported\n",
mask);
......@@ -294,7 +294,7 @@ static int isl29028_write_raw(struct iio_dev *indio_dev,
break;
case IIO_LIGHT:
if (mask != IIO_CHAN_INFO_SCALE_SEPARATE_BIT) {
if (mask != IIO_CHAN_INFO_SCALE) {
dev_err(chip->dev,
"light: mask value 0x%08lx not supported\n",
mask);
......@@ -349,14 +349,14 @@ static int isl29028_read_raw(struct iio_dev *indio_dev,
ret = IIO_VAL_INT;
break;
case IIO_CHAN_INFO_SAMP_FREQ_SEPARATE_BIT:
case IIO_CHAN_INFO_SAMP_FREQ:
if (chan->type != IIO_PROXIMITY)
break;
*val = chip->prox_sampling;
ret = IIO_VAL_INT;
break;
case IIO_CHAN_INFO_SCALE_SEPARATE_BIT:
case IIO_CHAN_INFO_SCALE:
if (chan->type != IIO_LIGHT)
break;
*val = chip->lux_scale;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment