Commit 89d9b1c9 authored by Linus Walleij's avatar Linus Walleij Committed by Samuel Ortiz

mfd: db8500-prcmu: Fix irqdomain usage

This fixes two issues with the DB8500 PRCMU irqdomain:
- You have to state the irq base 0 to get a linear domain
  for the DT case from irq_domain_add_simple()
- The irqdomain was not used to translate the initial irq
  request using irq_create_mapping() making the linear
  case fail as it was lacking a proper descriptor.

I took this opportunity to fix two lines of whitespace
errors in related code as I was anyway messing around with
it.

Cc: stable@kernel.org
Acked-by Lee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
parent ee487114
...@@ -2524,7 +2524,7 @@ static bool read_mailbox_0(void) ...@@ -2524,7 +2524,7 @@ static bool read_mailbox_0(void)
for (n = 0; n < NUM_PRCMU_WAKEUPS; n++) { for (n = 0; n < NUM_PRCMU_WAKEUPS; n++) {
if (ev & prcmu_irq_bit[n]) if (ev & prcmu_irq_bit[n])
generic_handle_irq(IRQ_PRCMU_BASE + n); generic_handle_irq(irq_find_mapping(db8500_irq_domain, n));
} }
r = true; r = true;
break; break;
...@@ -2737,13 +2737,14 @@ static int db8500_irq_map(struct irq_domain *d, unsigned int virq, ...@@ -2737,13 +2737,14 @@ static int db8500_irq_map(struct irq_domain *d, unsigned int virq,
} }
static struct irq_domain_ops db8500_irq_ops = { static struct irq_domain_ops db8500_irq_ops = {
.map = db8500_irq_map, .map = db8500_irq_map,
.xlate = irq_domain_xlate_twocell, .xlate = irq_domain_xlate_twocell,
}; };
static int db8500_irq_init(struct device_node *np) static int db8500_irq_init(struct device_node *np)
{ {
int irq_base = -1; int irq_base = 0;
int i;
/* In the device tree case, just take some IRQs */ /* In the device tree case, just take some IRQs */
if (!np) if (!np)
...@@ -2758,6 +2759,10 @@ static int db8500_irq_init(struct device_node *np) ...@@ -2758,6 +2759,10 @@ static int db8500_irq_init(struct device_node *np)
return -ENOSYS; return -ENOSYS;
} }
/* All wakeups will be used, so create mappings for all */
for (i = 0; i < NUM_PRCMU_WAKEUPS; i++)
irq_create_mapping(db8500_irq_domain, i);
return 0; return 0;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment