Commit 8a4e2742 authored by Isaku Yamahata's avatar Isaku Yamahata Committed by Paolo Bonzini

KVM: x86/tdp_mmu: Sprinkle __must_check

The TDP MMU function __tdp_mmu_set_spte_atomic uses a cmpxchg64 to replace
the SPTE value and returns -EBUSY on failure.  The caller must check the
return value and retry.  Add __must_check to it, as well as to two more
functions that forward the return value of __tdp_mmu_set_spte_atomic to
their caller.
Signed-off-by: default avatarIsaku Yamahata <isaku.yamahata@intel.com>
Reviewed-by: default avatarBinbin Wu <binbin.wu@linux.intel.com>
Message-Id: <8f7d5a1b241bf5351eaab828d1a1efe5c17699ca.1705965635.git.isaku.yamahata@intel.com>
Acked-by: default avatarKai Huang <kai.huang@intel.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent d8147384
...@@ -530,7 +530,8 @@ static void handle_changed_spte(struct kvm *kvm, int as_id, gfn_t gfn, ...@@ -530,7 +530,8 @@ static void handle_changed_spte(struct kvm *kvm, int as_id, gfn_t gfn,
kvm_set_pfn_accessed(spte_to_pfn(old_spte)); kvm_set_pfn_accessed(spte_to_pfn(old_spte));
} }
static inline int __tdp_mmu_set_spte_atomic(struct tdp_iter *iter, u64 new_spte) static inline int __must_check __tdp_mmu_set_spte_atomic(struct tdp_iter *iter,
u64 new_spte)
{ {
u64 *sptep = rcu_dereference(iter->sptep); u64 *sptep = rcu_dereference(iter->sptep);
...@@ -572,9 +573,9 @@ static inline int __tdp_mmu_set_spte_atomic(struct tdp_iter *iter, u64 new_spte) ...@@ -572,9 +573,9 @@ static inline int __tdp_mmu_set_spte_atomic(struct tdp_iter *iter, u64 new_spte)
* no side-effects other than setting iter->old_spte to the last * no side-effects other than setting iter->old_spte to the last
* known value of the spte. * known value of the spte.
*/ */
static inline int tdp_mmu_set_spte_atomic(struct kvm *kvm, static inline int __must_check tdp_mmu_set_spte_atomic(struct kvm *kvm,
struct tdp_iter *iter, struct tdp_iter *iter,
u64 new_spte) u64 new_spte)
{ {
int ret; int ret;
...@@ -590,8 +591,8 @@ static inline int tdp_mmu_set_spte_atomic(struct kvm *kvm, ...@@ -590,8 +591,8 @@ static inline int tdp_mmu_set_spte_atomic(struct kvm *kvm,
return 0; return 0;
} }
static inline int tdp_mmu_zap_spte_atomic(struct kvm *kvm, static inline int __must_check tdp_mmu_zap_spte_atomic(struct kvm *kvm,
struct tdp_iter *iter) struct tdp_iter *iter)
{ {
int ret; int ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment