Commit 8aa51d64 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller

openvswitch: checking wrong variable in queue_userspace_packet()

"skb" is non-NULL here, for example we dereference it in skb_clone().
The intent was to test "nskb" which was just set.
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarJesse Gross <jesse@nicira.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent b99215cd
...@@ -321,7 +321,7 @@ static int queue_userspace_packet(int dp_ifindex, struct sk_buff *skb, ...@@ -321,7 +321,7 @@ static int queue_userspace_packet(int dp_ifindex, struct sk_buff *skb,
return -ENOMEM; return -ENOMEM;
nskb = __vlan_put_tag(nskb, vlan_tx_tag_get(nskb)); nskb = __vlan_put_tag(nskb, vlan_tx_tag_get(nskb));
if (!skb) if (!nskb)
return -ENOMEM; return -ENOMEM;
nskb->vlan_tci = 0; nskb->vlan_tci = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment