Commit 8ae56822 authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso

netfilter: ipt_CLUSTERIP: put config struct if we can't increment ct refcount

This needs to put() the entry to avoid a resource leak in error path.
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 9cb9c07d
...@@ -496,12 +496,15 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par) ...@@ -496,12 +496,15 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par)
return PTR_ERR(config); return PTR_ERR(config);
} }
} }
cipinfo->config = config;
ret = nf_ct_netns_get(par->net, par->family); ret = nf_ct_netns_get(par->net, par->family);
if (ret < 0) if (ret < 0) {
pr_info("cannot load conntrack support for proto=%u\n", pr_info("cannot load conntrack support for proto=%u\n",
par->family); par->family);
clusterip_config_entry_put(par->net, config);
clusterip_config_put(config);
return ret;
}
if (!par->net->xt.clusterip_deprecated_warning) { if (!par->net->xt.clusterip_deprecated_warning) {
pr_info("ipt_CLUSTERIP is deprecated and it will removed soon, " pr_info("ipt_CLUSTERIP is deprecated and it will removed soon, "
...@@ -509,6 +512,7 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par) ...@@ -509,6 +512,7 @@ static int clusterip_tg_check(const struct xt_tgchk_param *par)
par->net->xt.clusterip_deprecated_warning = true; par->net->xt.clusterip_deprecated_warning = true;
} }
cipinfo->config = config;
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment