Commit 8aebfffa authored by Xiyu Yang's avatar Xiyu Yang Committed by Christoph Hellwig

configfs: fix config_item refcnt leak in configfs_rmdir()

configfs_rmdir() invokes configfs_get_config_item(), which returns a
reference of the specified config_item object to "parent_item" with
increased refcnt.

When configfs_rmdir() returns, local variable "parent_item" becomes
invalid, so the refcount should be decreased to keep refcount balanced.

The reference counting issue happens in one exception handling path of
configfs_rmdir(). When down_write_killable() fails, the function forgets
to decrease the refcnt increased by configfs_get_config_item(), causing
a refcnt leak.

Fix this issue by calling config_item_put() when down_write_killable()
fails.
Signed-off-by: default avatarXiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: default avatarXin Tan <tanxin.ctf@gmail.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 6a8b55ed
...@@ -1519,6 +1519,7 @@ static int configfs_rmdir(struct inode *dir, struct dentry *dentry) ...@@ -1519,6 +1519,7 @@ static int configfs_rmdir(struct inode *dir, struct dentry *dentry)
spin_lock(&configfs_dirent_lock); spin_lock(&configfs_dirent_lock);
configfs_detach_rollback(dentry); configfs_detach_rollback(dentry);
spin_unlock(&configfs_dirent_lock); spin_unlock(&configfs_dirent_lock);
config_item_put(parent_item);
return -EINTR; return -EINTR;
} }
frag->frag_dead = true; frag->frag_dead = true;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment