Commit 8aec4b87 authored by Nicholas Mc Guire's avatar Nicholas Mc Guire Committed by Alexandre Belloni

rtc: ds2404: use hw endiannes variable

Converting from hardware to host endiannes was done using reassignment
to the same variable which makes sparse unhappy as it can not verify
the endiannes handling properly. To allow sparse to verify endiannes
handling an explicit __le32 is introduced. Note that this patch does
not change the generated binary (x86_64 and ppc64 binary diff).
Signed-off-by: default avatarNicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent a188339c
...@@ -182,9 +182,10 @@ static void ds2404_enable_osc(struct device *dev) ...@@ -182,9 +182,10 @@ static void ds2404_enable_osc(struct device *dev)
static int ds2404_read_time(struct device *dev, struct rtc_time *dt) static int ds2404_read_time(struct device *dev, struct rtc_time *dt)
{ {
unsigned long time = 0; unsigned long time = 0;
__le32 hw_time = 0;
ds2404_read_memory(dev, 0x203, 4, (u8 *)&time); ds2404_read_memory(dev, 0x203, 4, (u8 *)&hw_time);
time = le32_to_cpu(time); time = le32_to_cpu(hw_time);
rtc_time64_to_tm(time, dt); rtc_time64_to_tm(time, dt);
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment