Commit 8b6d457f authored by Chris Wilson's avatar Chris Wilson

drm/i915/execlists: Include priority info in trace_ports

Add some extra information into trace_ports to help with reviewing
correctness.
Signed-off-by: default avatarChris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200330113137.24425-1-chris@chris-wilson.co.uk
parent d472634e
...@@ -1415,6 +1415,23 @@ static inline void write_desc(struct intel_engine_execlists *execlists, u64 desc ...@@ -1415,6 +1415,23 @@ static inline void write_desc(struct intel_engine_execlists *execlists, u64 desc
} }
} }
static __maybe_unused char *
dump_port(char *buf, int buflen, const char *prefix, struct i915_request *rq)
{
if (!rq)
return "";
snprintf(buf, buflen, "%s%llx:%lld%s prio %d",
prefix,
rq->fence.context, rq->fence.seqno,
i915_request_completed(rq) ? "!" :
i915_request_started(rq) ? "*" :
"",
rq_prio(rq));
return buf;
}
static __maybe_unused void static __maybe_unused void
trace_ports(const struct intel_engine_execlists *execlists, trace_ports(const struct intel_engine_execlists *execlists,
const char *msg, const char *msg,
...@@ -1422,18 +1439,14 @@ trace_ports(const struct intel_engine_execlists *execlists, ...@@ -1422,18 +1439,14 @@ trace_ports(const struct intel_engine_execlists *execlists,
{ {
const struct intel_engine_cs *engine = const struct intel_engine_cs *engine =
container_of(execlists, typeof(*engine), execlists); container_of(execlists, typeof(*engine), execlists);
char __maybe_unused p0[40], p1[40];
if (!ports[0]) if (!ports[0])
return; return;
ENGINE_TRACE(engine, "%s { %llx:%lld%s, %llx:%lld }\n", msg, ENGINE_TRACE(engine, "%s { %s%s }\n", msg,
ports[0]->fence.context, dump_port(p0, sizeof(p0), "", ports[0]),
ports[0]->fence.seqno, dump_port(p1, sizeof(p1), ", ", ports[1]));
i915_request_completed(ports[0]) ? "!" :
i915_request_started(ports[0]) ? "*" :
"",
ports[1] ? ports[1]->fence.context : 0,
ports[1] ? ports[1]->fence.seqno : 0);
} }
static inline bool static inline bool
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment