Commit 8bc613be authored by Rickard Strandqvist's avatar Rickard Strandqvist Committed by James Hogan

metag: hugetlbpage: Remove null pointer checks that could never happen

There are inconsistent NULL checks in
hugetlb_get_unmapped_area_existing(). The last conditional block in the
loop checks vma, but vma is dereferenced after that.

Due to the checks above however (bearing in mind after_huge is either 0
or 1) vma is guaranteed not to be NULL here, so remove that part of the
check.
Signed-off-by: default avatarRickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
[james.hogan@imgtec.com: remove brackets and expand commit message]
Signed-off-by: default avatarJames Hogan <james.hogan@imgtec.com>
parent 7171511e
...@@ -173,7 +173,7 @@ hugetlb_get_unmapped_area_existing(unsigned long len) ...@@ -173,7 +173,7 @@ hugetlb_get_unmapped_area_existing(unsigned long len)
mm->context.part_huge = 0; mm->context.part_huge = 0;
return addr; return addr;
} }
if (vma && (vma->vm_flags & MAP_HUGETLB)) { if (vma->vm_flags & MAP_HUGETLB) {
/* space after a huge vma in 2nd level page table? */ /* space after a huge vma in 2nd level page table? */
if (vma->vm_end & HUGEPT_MASK) { if (vma->vm_end & HUGEPT_MASK) {
after_huge = 1; after_huge = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment