Commit 8c91ca76 authored by Kamil Duljas's avatar Kamil Duljas Committed by Mark Brown

ASoC: SOF: icp3-dtrace: Fix wrong kfree() usage

trace_filter_parse() allocs memory for *out and when
-ENOMEM is returned, caller function, dfsentry_trace_filter_write()
trying to freed this memory.

After this patch, the memory is freed in trace_filter_parse()
before -EINVAL returned. In caller function removed kfree(elms)
from error label
Signed-off-by: default avatarKamil Duljas <kamil.duljas@gmail.com>
Link: https://lore.kernel.org/r/20231116220102.2097-2-kamil.duljas@gmail.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent ef858b61
...@@ -137,6 +137,7 @@ static int trace_filter_parse(struct snd_sof_dev *sdev, char *string, ...@@ -137,6 +137,7 @@ static int trace_filter_parse(struct snd_sof_dev *sdev, char *string,
dev_err(sdev->dev, dev_err(sdev->dev,
"Parsing filter entry '%s' failed with %d\n", "Parsing filter entry '%s' failed with %d\n",
entry, entry_len); entry, entry_len);
kfree(*out);
return -EINVAL; return -EINVAL;
} }
} }
...@@ -208,13 +209,13 @@ static ssize_t dfsentry_trace_filter_write(struct file *file, const char __user ...@@ -208,13 +209,13 @@ static ssize_t dfsentry_trace_filter_write(struct file *file, const char __user
ret = ipc3_trace_update_filter(sdev, num_elems, elems); ret = ipc3_trace_update_filter(sdev, num_elems, elems);
if (ret < 0) { if (ret < 0) {
dev_err(sdev->dev, "Filter update failed: %d\n", ret); dev_err(sdev->dev, "Filter update failed: %d\n", ret);
kfree(elems);
goto error; goto error;
} }
} }
ret = count; ret = count;
error: error:
kfree(string); kfree(string);
kfree(elems);
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment