Commit 8cd3dc19 authored by Alex Dewar's avatar Alex Dewar Committed by Greg Kroah-Hartman

staging/emxx_udc: Remove pointless variable assignments

In a number of places in emxx_udc.c, there are variables which are
assigned to without that value ever being used. Remove these pointless
assignments.
Reported-by: default avatarkernel test robot <lkp@intel.com>
Fixes: 33aa8d45 ("staging: emxx_udc: Add Emma Mobile USB Gadget driver")
Signed-off-by: default avatarAlex Dewar <alex.dewar90@gmail.com>
Link: https://lore.kernel.org/r/20200902154628.283453-1-alex.dewar90@gmail.comSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4c6491a3
...@@ -793,7 +793,7 @@ static int _nbu2ss_out_dma(struct nbu2ss_udc *udc, struct nbu2ss_req *req, ...@@ -793,7 +793,7 @@ static int _nbu2ss_out_dma(struct nbu2ss_udc *udc, struct nbu2ss_req *req,
u32 dmacnt; u32 dmacnt;
u32 burst = 1; u32 burst = 1;
u32 data; u32 data;
int result = -EINVAL; int result;
struct fc_regs __iomem *preg = udc->p_regs; struct fc_regs __iomem *preg = udc->p_regs;
if (req->dma_flag) if (req->dma_flag)
...@@ -1288,8 +1288,6 @@ static void _nbu2ss_set_endpoint_stall(struct nbu2ss_udc *udc, ...@@ -1288,8 +1288,6 @@ static void _nbu2ss_set_endpoint_stall(struct nbu2ss_udc *udc,
_nbu2ss_bitset(&preg->EP_REGS[num].EP_CONTROL, data); _nbu2ss_bitset(&preg->EP_REGS[num].EP_CONTROL, data);
} else { } else {
/* Clear STALL */
ep->stalled = false;
if (ep_adrs & USB_DIR_IN) { if (ep_adrs & USB_DIR_IN) {
_nbu2ss_bitclr(&preg->EP_REGS[num].EP_CONTROL _nbu2ss_bitclr(&preg->EP_REGS[num].EP_CONTROL
, EPN_ISTL); , EPN_ISTL);
...@@ -1304,6 +1302,7 @@ static void _nbu2ss_set_endpoint_stall(struct nbu2ss_udc *udc, ...@@ -1304,6 +1302,7 @@ static void _nbu2ss_set_endpoint_stall(struct nbu2ss_udc *udc,
, data); , data);
} }
/* Clear STALL */
ep->stalled = false; ep->stalled = false;
if (ep->halted) { if (ep->halted) {
ep->halted = false; ep->halted = false;
...@@ -3073,8 +3072,8 @@ static int nbu2ss_drv_contest_init(struct platform_device *pdev, ...@@ -3073,8 +3072,8 @@ static int nbu2ss_drv_contest_init(struct platform_device *pdev,
*/ */
static int nbu2ss_drv_probe(struct platform_device *pdev) static int nbu2ss_drv_probe(struct platform_device *pdev)
{ {
int status = -ENODEV; int status;
struct nbu2ss_udc *udc; struct nbu2ss_udc *udc;
int irq; int irq;
void __iomem *mmio_base; void __iomem *mmio_base;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment