Commit 8d130c3b authored by Jian Yu's avatar Jian Yu Committed by Greg Kroah-Hartman

staging/lustre: Use proper number of bytes in copy_from_user

This patch removes the usage of MAX_STRING_SIZE from
copy_from_user() and just copies enough bytes to cover
count passed in.
Signed-off-by: default avatarJian Yu <jian.yu@intel.com>
Reviewed-on: http://review.whamcloud.com/23462
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8774Reviewed-by: default avatarJohn L. Hammond <john.hammond@intel.com>
Signed-off-by: default avatarOleg Drokin <green@linuxhacker.ru>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 35487271
...@@ -400,10 +400,17 @@ int lprocfs_wr_uint(struct file *file, const char __user *buffer, ...@@ -400,10 +400,17 @@ int lprocfs_wr_uint(struct file *file, const char __user *buffer,
char dummy[MAX_STRING_SIZE + 1], *end; char dummy[MAX_STRING_SIZE + 1], *end;
unsigned long tmp; unsigned long tmp;
dummy[MAX_STRING_SIZE] = '\0'; if (count >= sizeof(dummy))
if (copy_from_user(dummy, buffer, MAX_STRING_SIZE)) return -EINVAL;
if (count == 0)
return 0;
if (copy_from_user(dummy, buffer, count))
return -EFAULT; return -EFAULT;
dummy[count] = '\0';
tmp = simple_strtoul(dummy, &end, 0); tmp = simple_strtoul(dummy, &end, 0);
if (dummy == end) if (dummy == end)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment