Commit 8d160f6b authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Kishon Vijay Abraham I

phy: marvell: phy-armada38x-comphy: Add of_node_put() before return

Each iteration of for_each_available_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return.
Issue found with Coccinelle.
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 4e99276a
...@@ -200,8 +200,10 @@ static int a38x_comphy_probe(struct platform_device *pdev) ...@@ -200,8 +200,10 @@ static int a38x_comphy_probe(struct platform_device *pdev)
} }
phy = devm_phy_create(&pdev->dev, child, &a38x_comphy_ops); phy = devm_phy_create(&pdev->dev, child, &a38x_comphy_ops);
if (IS_ERR(phy)) if (IS_ERR(phy)) {
of_node_put(child);
return PTR_ERR(phy); return PTR_ERR(phy);
}
priv->lane[val].base = base + 0x28 * val; priv->lane[val].base = base + 0x28 * val;
priv->lane[val].priv = priv; priv->lane[val].priv = priv;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment