Commit 8df09ea3 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

[SOCK] Avoid integer divides where not necessary in include/net/sock.h

Because sk_wmem_queued, sk_sndbuf are signed, a divide per two
may force compiler to use an integer divide.

We can instead use a right shift.
Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ce55dd36
...@@ -445,7 +445,7 @@ static inline int sk_acceptq_is_full(struct sock *sk) ...@@ -445,7 +445,7 @@ static inline int sk_acceptq_is_full(struct sock *sk)
*/ */
static inline int sk_stream_min_wspace(struct sock *sk) static inline int sk_stream_min_wspace(struct sock *sk)
{ {
return sk->sk_wmem_queued / 2; return sk->sk_wmem_queued >> 1;
} }
static inline int sk_stream_wspace(struct sock *sk) static inline int sk_stream_wspace(struct sock *sk)
...@@ -1187,7 +1187,7 @@ static inline void sk_wake_async(struct sock *sk, int how, int band) ...@@ -1187,7 +1187,7 @@ static inline void sk_wake_async(struct sock *sk, int how, int band)
static inline void sk_stream_moderate_sndbuf(struct sock *sk) static inline void sk_stream_moderate_sndbuf(struct sock *sk)
{ {
if (!(sk->sk_userlocks & SOCK_SNDBUF_LOCK)) { if (!(sk->sk_userlocks & SOCK_SNDBUF_LOCK)) {
sk->sk_sndbuf = min(sk->sk_sndbuf, sk->sk_wmem_queued / 2); sk->sk_sndbuf = min(sk->sk_sndbuf, sk->sk_wmem_queued >> 1);
sk->sk_sndbuf = max(sk->sk_sndbuf, SOCK_MIN_SNDBUF); sk->sk_sndbuf = max(sk->sk_sndbuf, SOCK_MIN_SNDBUF);
} }
} }
...@@ -1211,7 +1211,7 @@ static inline struct page *sk_stream_alloc_page(struct sock *sk) ...@@ -1211,7 +1211,7 @@ static inline struct page *sk_stream_alloc_page(struct sock *sk)
*/ */
static inline int sock_writeable(const struct sock *sk) static inline int sock_writeable(const struct sock *sk)
{ {
return atomic_read(&sk->sk_wmem_alloc) < (sk->sk_sndbuf / 2); return atomic_read(&sk->sk_wmem_alloc) < (sk->sk_sndbuf >> 1);
} }
static inline gfp_t gfp_any(void) static inline gfp_t gfp_any(void)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment