Commit 8df0a663 authored by Kevin Hilman's avatar Kevin Hilman

cpufreq: OMAP: ensure valid clock rate before scaling

Ensure the clock rate that will be used is a valid one before
attempting to scale the voltage.  Currently the driver assumes it has
a valid frequency from the OPP table, but boards using different
system oscillators might not have exact matches with the OPP table,
and result in a failing call to clk_set_rate().

This is particularily bad because the voltage may be scaled even
though the frequency is not.  This will obviously lead to some
unpredictable behavior, especially if the frequency is high and
the voltage is dropped.

Thanks to Joni Lapilainen for reporting crashes seen on 3430/n900.
Reported-by: default avatarJoni Lapilainen <joni.lapilainen@gmail.com>
Acked-by: default avatarRafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: default avatarKevin Hilman <khilman@ti.com>
parent 16642a2e
...@@ -108,6 +108,14 @@ static int omap_target(struct cpufreq_policy *policy, ...@@ -108,6 +108,14 @@ static int omap_target(struct cpufreq_policy *policy,
} }
freq = freqs.new * 1000; freq = freqs.new * 1000;
ret = clk_round_rate(mpu_clk, freq);
if (IS_ERR_VALUE(ret)) {
dev_warn(mpu_dev,
"CPUfreq: Cannot find matching frequency for %lu\n",
freq);
return ret;
}
freq = ret;
if (mpu_reg) { if (mpu_reg) {
opp = opp_find_freq_ceil(mpu_dev, &freq); opp = opp_find_freq_ceil(mpu_dev, &freq);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment