Commit 8e90b4b1 authored by Vasily Gorbik's avatar Vasily Gorbik Committed by Heiko Carstens

s390: correct __bootdata / __bootdata_preserved macros

Currently s390 build is broken.

  SECTCMP .boot.data
error: section .boot.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
make[2]: *** [arch/s390/boot/section_cmp.boot.data] Error 1
  SECTCMP .boot.preserved.data
error: section .boot.preserved.data differs between vmlinux and arch/s390/boot/compressed/vmlinux
make[2]: *** [arch/s390/boot/section_cmp.boot.preserved.data] Error 1
make[1]: *** [bzImage] Error 2

Commit 33def849 ("treewide: Convert macro and uses of __section(foo)
to __section("foo")") converted all __section(foo) to __section("foo").
This is wrong for __bootdata / __bootdata_preserved macros which want
variable names to be a part of intermediate section names .boot.data.<var
name> and .boot.preserved.data.<var name>. Those sections are later
sorted by alignment + name and merged together into final .boot.data
/ .boot.preserved.data sections. Those sections must be identical in
the decompressor and the decompressed kernel (that is checked during
the build).

Fixes: 33def849 ("treewide: Convert macro and uses of __section(foo) to __section("foo")")
Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
parent 3650b228
...@@ -26,14 +26,14 @@ static inline int arch_is_kernel_initmem_freed(unsigned long addr) ...@@ -26,14 +26,14 @@ static inline int arch_is_kernel_initmem_freed(unsigned long addr)
* final .boot.data section, which should be identical in the decompressor and * final .boot.data section, which should be identical in the decompressor and
* the decompressed kernel (that is checked during the build). * the decompressed kernel (that is checked during the build).
*/ */
#define __bootdata(var) __section(".boot.data.var") var #define __bootdata(var) __section(".boot.data." #var) var
/* /*
* .boot.preserved.data is similar to .boot.data, but it is not part of the * .boot.preserved.data is similar to .boot.data, but it is not part of the
* .init section and thus will be preserved for later use in the decompressed * .init section and thus will be preserved for later use in the decompressed
* kernel. * kernel.
*/ */
#define __bootdata_preserved(var) __section(".boot.preserved.data.var") var #define __bootdata_preserved(var) __section(".boot.preserved.data." #var) var
extern unsigned long __sdma, __edma; extern unsigned long __sdma, __edma;
extern unsigned long __stext_dma, __etext_dma; extern unsigned long __stext_dma, __etext_dma;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment