Commit 8e9204cd authored by Marek Szyprowski's avatar Marek Szyprowski Committed by Mark Brown

spi: Ensure that sg_table won't be used after being freed

SPI code checks for non-zero sgt->orig_nents to determine if the buffer
has been DMA-mapped. Ensure that sg_table is really zeroed after free to
avoid potential NULL pointer dereference if the given SPI xfer object is
reused again without being DMA-mapped.

Fixes: 0c17ba73 ("spi: Fix cache corruption due to DMA/PIO overlap")
Signed-off-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20220930113408.19720-1-m.szyprowski@samsung.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
parent 28366dd2
...@@ -1102,6 +1102,8 @@ static void spi_unmap_buf_attrs(struct spi_controller *ctlr, ...@@ -1102,6 +1102,8 @@ static void spi_unmap_buf_attrs(struct spi_controller *ctlr,
if (sgt->orig_nents) { if (sgt->orig_nents) {
dma_unmap_sgtable(dev, sgt, dir, attrs); dma_unmap_sgtable(dev, sgt, dir, attrs);
sg_free_table(sgt); sg_free_table(sgt);
sgt->orig_nents = 0;
sgt->nents = 0;
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment