Commit 8ea360d4 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] vmscan: revert may_enter_fs changes

Fix up the "may we call writepage" logic for the swapcache changes.
parent e74193ad
...@@ -247,7 +247,6 @@ static int ...@@ -247,7 +247,6 @@ static int
shrink_list(struct list_head *page_list, unsigned int gfp_mask, shrink_list(struct list_head *page_list, unsigned int gfp_mask,
int *nr_scanned, int do_writepage) int *nr_scanned, int do_writepage)
{ {
struct address_space *mapping;
LIST_HEAD(ret_pages); LIST_HEAD(ret_pages);
struct pagevec freed_pvec; struct pagevec freed_pvec;
int pgactivate = 0; int pgactivate = 0;
...@@ -257,6 +256,7 @@ shrink_list(struct list_head *page_list, unsigned int gfp_mask, ...@@ -257,6 +256,7 @@ shrink_list(struct list_head *page_list, unsigned int gfp_mask,
pagevec_init(&freed_pvec, 1); pagevec_init(&freed_pvec, 1);
while (!list_empty(page_list)) { while (!list_empty(page_list)) {
struct address_space *mapping;
struct page *page; struct page *page;
int may_enter_fs; int may_enter_fs;
int referenced; int referenced;
...@@ -284,9 +284,6 @@ shrink_list(struct list_head *page_list, unsigned int gfp_mask, ...@@ -284,9 +284,6 @@ shrink_list(struct list_head *page_list, unsigned int gfp_mask,
goto activate_locked; goto activate_locked;
} }
mapping = page_mapping(page);
may_enter_fs = (gfp_mask & __GFP_FS);
#ifdef CONFIG_SWAP #ifdef CONFIG_SWAP
/* /*
* Anonymous process memory has backing store? * Anonymous process memory has backing store?
...@@ -300,12 +297,12 @@ shrink_list(struct list_head *page_list, unsigned int gfp_mask, ...@@ -300,12 +297,12 @@ shrink_list(struct list_head *page_list, unsigned int gfp_mask,
goto activate_locked; goto activate_locked;
page_map_lock(page); page_map_lock(page);
} }
if (PageSwapCache(page)) {
mapping = &swapper_space;
may_enter_fs = (gfp_mask & __GFP_IO);
}
#endif /* CONFIG_SWAP */ #endif /* CONFIG_SWAP */
mapping = page_mapping(page);
may_enter_fs = (gfp_mask & __GFP_FS) ||
(PageSwapCache(page) && (gfp_mask & __GFP_IO));
/* /*
* The page is mapped into the page tables of one or more * The page is mapped into the page tables of one or more
* processes. Try to unmap it here. * processes. Try to unmap it here.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment