Commit 8f474287 authored by Julia Lawall's avatar Julia Lawall Committed by Tejun Heo

ataflop: adjust NULL test

dtp is derefenced on the lines above the test !dtp, and so it cannot be
NULL at this point.

A simplified version of the semantic match that finds this problem is as
follows: (http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r@
expression x,E,E1;
identifier f,l;
position p1,p2;
@@

*x@p1->f = E1;
... when != x = E
    when != goto l;
(
*x@p2 == NULL
|
*x@p2 != NULL
)
// </smpl>
Signed-off-by: default avatarJulia Lawall <julia@diku.dk>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent 0a09f431
...@@ -1627,7 +1627,7 @@ static int fd_ioctl(struct block_device *bdev, fmode_t mode, ...@@ -1627,7 +1627,7 @@ static int fd_ioctl(struct block_device *bdev, fmode_t mode,
drive, dtp->blocks, dtp->spt, dtp->stretch); drive, dtp->blocks, dtp->spt, dtp->stretch);
/* sanity check */ /* sanity check */
if (!dtp || setprm.track != dtp->blocks/dtp->spt/2 || if (setprm.track != dtp->blocks/dtp->spt/2 ||
setprm.head != 2) { setprm.head != 2) {
redo_fd_request(); redo_fd_request();
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment