Commit 8f9cde23 authored by Jonathan Cameron's avatar Jonathan Cameron Committed by Greg Kroah-Hartman

staging:iio:adc:adt7310/7410 sticking plaster fix for broken event attrs.

Neither of these drivers has ever been anywhere near the iio abi.
Probably as a result of this the fact they had two event groups
each was not picked up when we restricted IIO to having only
1 event line per device (as part of the chrdev merge set).

As such these definitely didn't work before.  This patch squishes
the only element from the 'comparator' event line that isn't in the
'interrupt' one into it and kills off the 'comparator' one.

Ultimately both of these drivers belong in hwmon not IIO and are just
waiting here because I don't want to kill off a driver that may
prove useful to someone.  (Ultimately I will ask Greg to scrap
these two if no one steps up to deal with them.)
Signed-off-by: default avatarJonathan Cameron <jic23@kernel.org>
Acked-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9214cc6e
...@@ -725,32 +725,19 @@ static struct attribute *adt7310_event_int_attributes[] = { ...@@ -725,32 +725,19 @@ static struct attribute *adt7310_event_int_attributes[] = {
&iio_dev_attr_fault_queue.dev_attr.attr, &iio_dev_attr_fault_queue.dev_attr.attr,
&iio_dev_attr_t_alarm_high.dev_attr.attr, &iio_dev_attr_t_alarm_high.dev_attr.attr,
&iio_dev_attr_t_alarm_low.dev_attr.attr, &iio_dev_attr_t_alarm_low.dev_attr.attr,
&iio_dev_attr_t_hyst.dev_attr.attr,
NULL,
};
static struct attribute *adt7310_event_ct_attributes[] = {
&iio_dev_attr_event_mode.dev_attr.attr,
&iio_dev_attr_available_event_modes.dev_attr.attr,
&iio_dev_attr_fault_queue.dev_attr.attr,
&iio_dev_attr_t_crit.dev_attr.attr, &iio_dev_attr_t_crit.dev_attr.attr,
&iio_dev_attr_t_hyst.dev_attr.attr, &iio_dev_attr_t_hyst.dev_attr.attr,
NULL, NULL,
}; };
static struct attribute_group adt7310_event_attribute_group[ADT7310_IRQS] = { static struct attribute_group adt7310_event_attribute_group = {
{ .attrs = adt7310_event_int_attributes,
.attrs = adt7310_event_int_attributes, .name = "events",
.name = "events",
}, {
.attrs = adt7310_event_ct_attributes,
.name = "events",
}
}; };
static const struct iio_info adt7310_info = { static const struct iio_info adt7310_info = {
.attrs = &adt7310_attribute_group, .attrs = &adt7310_attribute_group,
.event_attrs = adt7310_event_attribute_group, .event_attrs = &adt7310_event_attribute_group,
.driver_module = THIS_MODULE, .driver_module = THIS_MODULE,
}; };
......
...@@ -693,32 +693,19 @@ static struct attribute *adt7410_event_int_attributes[] = { ...@@ -693,32 +693,19 @@ static struct attribute *adt7410_event_int_attributes[] = {
&iio_dev_attr_fault_queue.dev_attr.attr, &iio_dev_attr_fault_queue.dev_attr.attr,
&iio_dev_attr_t_alarm_high.dev_attr.attr, &iio_dev_attr_t_alarm_high.dev_attr.attr,
&iio_dev_attr_t_alarm_low.dev_attr.attr, &iio_dev_attr_t_alarm_low.dev_attr.attr,
&iio_dev_attr_t_hyst.dev_attr.attr,
NULL,
};
static struct attribute *adt7410_event_ct_attributes[] = {
&iio_dev_attr_event_mode.dev_attr.attr,
&iio_dev_attr_available_event_modes.dev_attr.attr,
&iio_dev_attr_fault_queue.dev_attr.attr,
&iio_dev_attr_t_crit.dev_attr.attr, &iio_dev_attr_t_crit.dev_attr.attr,
&iio_dev_attr_t_hyst.dev_attr.attr, &iio_dev_attr_t_hyst.dev_attr.attr,
NULL, NULL,
}; };
static struct attribute_group adt7410_event_attribute_group[ADT7410_IRQS] = { static struct attribute_group adt7410_event_attribute_group = {
{ .attrs = adt7410_event_int_attributes,
.attrs = adt7410_event_int_attributes, .name = "events",
.name = "events",
}, {
.attrs = adt7410_event_ct_attributes,
.name = "events",
}
}; };
static const struct iio_info adt7410_info = { static const struct iio_info adt7410_info = {
.attrs = &adt7410_attribute_group, .attrs = &adt7410_attribute_group,
.event_attrs = adt7410_event_attribute_group, .event_attrs = &adt7410_event_attribute_group,
.driver_module = THIS_MODULE, .driver_module = THIS_MODULE,
}; };
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment