Commit 8fa2186c authored by Neil Brown's avatar Neil Brown Committed by Linus Torvalds

[PATCH] Fix raid1 read_balancing code.

The meaning of mddev->in_sync changed subtly a while ago, and raid1 wasn't
changed to match.  This results in raid1 read_balancing not working
properly.  This patch corrects the relevant test.
Signed-off-by: default avatarNeil Brown <neilb@cse.unsw.edu.au>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent eeaa31cc
......@@ -376,7 +376,8 @@ static int read_balance(conf_t *conf, struct bio *bio, r1bio_t *r1_bio)
* device if no resync is going on, or below the resync window.
* We take the first readable disk when above the resync window.
*/
if (!conf->mddev->in_sync && (this_sector + sectors >= conf->next_resync)) {
if (conf->mddev->recovery_cp < MaxSector &&
(this_sector + sectors >= conf->next_resync)) {
/* make sure that disk is operational */
new_disk = 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment