Commit 8fedaaca authored by Florian Fainelli's avatar Florian Fainelli Committed by Jakub Kicinski

net: dsa: tag_rtl4_a: Use existing ETH_P_REALTEK constant

No functional change, uses the existing ETH_P_REALTEK constant already
defined in if_ether.h.
Signed-off-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Reviewed-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Link: https://lore.kernel.org/r/20231113165030.2440083-1-florian.fainelli@broadcom.comSigned-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 89cdf9d5
...@@ -23,7 +23,6 @@ ...@@ -23,7 +23,6 @@
#define RTL4_A_NAME "rtl4a" #define RTL4_A_NAME "rtl4a"
#define RTL4_A_HDR_LEN 4 #define RTL4_A_HDR_LEN 4
#define RTL4_A_ETHERTYPE 0x8899
#define RTL4_A_PROTOCOL_SHIFT 12 #define RTL4_A_PROTOCOL_SHIFT 12
/* /*
* 0x1 = Realtek Remote Control protocol (RRCP) * 0x1 = Realtek Remote Control protocol (RRCP)
...@@ -54,7 +53,7 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb, ...@@ -54,7 +53,7 @@ static struct sk_buff *rtl4a_tag_xmit(struct sk_buff *skb,
/* Set Ethertype */ /* Set Ethertype */
p = (__be16 *)tag; p = (__be16 *)tag;
*p = htons(RTL4_A_ETHERTYPE); *p = htons(ETH_P_REALTEK);
out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT); out = (RTL4_A_PROTOCOL_RTL8366RB << RTL4_A_PROTOCOL_SHIFT);
/* The lower bits indicate the port number */ /* The lower bits indicate the port number */
...@@ -82,7 +81,7 @@ static struct sk_buff *rtl4a_tag_rcv(struct sk_buff *skb, ...@@ -82,7 +81,7 @@ static struct sk_buff *rtl4a_tag_rcv(struct sk_buff *skb,
tag = dsa_etype_header_pos_rx(skb); tag = dsa_etype_header_pos_rx(skb);
p = (__be16 *)tag; p = (__be16 *)tag;
etype = ntohs(*p); etype = ntohs(*p);
if (etype != RTL4_A_ETHERTYPE) { if (etype != ETH_P_REALTEK) {
/* Not custom, just pass through */ /* Not custom, just pass through */
netdev_dbg(dev, "non-realtek ethertype 0x%04x\n", etype); netdev_dbg(dev, "non-realtek ethertype 0x%04x\n", etype);
return skb; return skb;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment