Commit 9049453a authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Bjorn Andersson

soc: qcom: pmic_glink: add CONFIG_NET/CONFIG_OF dependencies

QMI is a network protocol, so anything using requires CONFIG_NET
to be enabled as well:

WARNING: unmet direct dependencies detected for QCOM_QMI_HELPERS
  Depends on [n]: NET [=n]
  Selected by [m]:
  - QCOM_PDR_HELPERS [=m]
arm-linux-gnueabi-ld: drivers/soc/qcom/qmi_interface.o: in function `qmi_send_new_lookup':
qmi_interface.c:(.text+0xf0): undefined reference to `kernel_sendmsg'

Add the dependency to both QCOM_PDR_HELPERS and QCOM_PMIC_GLINK to make
it clearly what the dependency is when another PDR user is added.

pmic_glink also needs CONFIG_OF:

drivers/soc/qcom/pmic_glink_altmode.c: In function 'pmic_glink_altmode_probe':
drivers/soc/qcom/pmic_glink_altmode.c:418:33: error: 'struct drm_bridge' has no member named 'of_node'

Fixes: 58ef4ece ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230206193804.191343-1-arnd@kernel.org
parent 9b4a1915
...@@ -91,12 +91,15 @@ config QCOM_OCMEM ...@@ -91,12 +91,15 @@ config QCOM_OCMEM
config QCOM_PDR_HELPERS config QCOM_PDR_HELPERS
tristate tristate
select QCOM_QMI_HELPERS select QCOM_QMI_HELPERS
depends on NET
config QCOM_PMIC_GLINK config QCOM_PMIC_GLINK
tristate "Qualcomm PMIC GLINK driver" tristate "Qualcomm PMIC GLINK driver"
depends on RPMSG depends on RPMSG
depends on TYPEC depends on TYPEC
depends on DRM depends on DRM
depends on NET
depends on OF
select AUXILIARY_BUS select AUXILIARY_BUS
select QCOM_PDR_HELPERS select QCOM_PDR_HELPERS
help help
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment