Commit 90d4fa45 authored by Richard Weinberger's avatar Richard Weinberger Committed by Cyrille Pitchen

mtd: spi-nor: Kill check with no effect

header.minor is of type u8 and cannot be negative.

Detected by CoverityScan CID#1417858 ("Integer handling issues")

Fixes: f384b352 ("mtd: spi-nor: parse Serial Flash Discoverable
Parameters (SFDP) tables")
Signed-off-by: default avatarRichard Weinberger <richard@nod.at>
Signed-off-by: default avatarCyrille Pitchen <cyrille.pitchen@wedev4u.fr>
parent 8a5776a5
...@@ -2288,8 +2288,7 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor, ...@@ -2288,8 +2288,7 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor,
/* Check the SFDP header version. */ /* Check the SFDP header version. */
if (le32_to_cpu(header.signature) != SFDP_SIGNATURE || if (le32_to_cpu(header.signature) != SFDP_SIGNATURE ||
header.major != SFDP_JESD216_MAJOR || header.major != SFDP_JESD216_MAJOR)
header.minor < SFDP_JESD216_MINOR)
return -EINVAL; return -EINVAL;
/* /*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment