Commit 90e8f57c authored by Anton Blanchard's avatar Anton Blanchard Committed by Benjamin Herrenschmidt

powerpc/xics: Reset the CPPR if H_EOI fails

I have an intermittent kdump fail where the hypervisor fails an H_EOI.
As a result our CPPR is never reset to 0xff and we no longer accept
interrupts.

This patch calls icp_hv_set_cppr to reset the CPPR if H_EOI fails,
fixing the kdump fail.
Signed-off-by: default avatarAnton Blanchard <anton@samba.org>
Signed-off-by: default avatarBenjamin Herrenschmidt <benh@kernel.crashing.org>
parent a934904d
...@@ -41,23 +41,24 @@ static inline unsigned int icp_hv_get_xirr(unsigned char cppr) ...@@ -41,23 +41,24 @@ static inline unsigned int icp_hv_get_xirr(unsigned char cppr)
return ret; return ret;
} }
static inline void icp_hv_set_xirr(unsigned int value) static inline void icp_hv_set_cppr(u8 value)
{ {
long rc = plpar_hcall_norets(H_EOI, value); long rc = plpar_hcall_norets(H_CPPR, value);
if (rc != H_SUCCESS) { if (rc != H_SUCCESS) {
pr_err("%s: bad return code eoi xirr=0x%x returned %ld\n", pr_err("%s: bad return code cppr cppr=0x%x returned %ld\n",
__func__, value, rc); __func__, value, rc);
WARN_ON_ONCE(1); WARN_ON_ONCE(1);
} }
} }
static inline void icp_hv_set_cppr(u8 value) static inline void icp_hv_set_xirr(unsigned int value)
{ {
long rc = plpar_hcall_norets(H_CPPR, value); long rc = plpar_hcall_norets(H_EOI, value);
if (rc != H_SUCCESS) { if (rc != H_SUCCESS) {
pr_err("%s: bad return code cppr cppr=0x%x returned %ld\n", pr_err("%s: bad return code eoi xirr=0x%x returned %ld\n",
__func__, value, rc); __func__, value, rc);
WARN_ON_ONCE(1); WARN_ON_ONCE(1);
icp_hv_set_cppr(value >> 24);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment