Commit 90f15ac9 authored by Fuqian Huang's avatar Fuqian Huang Committed by Jan Kara

ext2: Use kmemdup rather than duplicating its implementation

kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memset, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memset.
Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Link: https://lore.kernel.org/r/20190703131727.25735-1-huangfq.daxian@gmail.comSigned-off-by: default avatarJan Kara <jack@suse.cz>
parent 555b2c3d
...@@ -532,11 +532,10 @@ ext2_xattr_set(struct inode *inode, int name_index, const char *name, ...@@ -532,11 +532,10 @@ ext2_xattr_set(struct inode *inode, int name_index, const char *name,
unlock_buffer(bh); unlock_buffer(bh);
ea_bdebug(bh, "cloning"); ea_bdebug(bh, "cloning");
header = kmalloc(bh->b_size, GFP_KERNEL); header = kmemdup(HDR(bh), bh->b_size, GFP_KERNEL);
error = -ENOMEM; error = -ENOMEM;
if (header == NULL) if (header == NULL)
goto cleanup; goto cleanup;
memcpy(header, HDR(bh), bh->b_size);
header->h_refcount = cpu_to_le32(1); header->h_refcount = cpu_to_le32(1);
offset = (char *)here - bh->b_data; offset = (char *)here - bh->b_data;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment