Commit 91510d59 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski

gpio: cdev: fix a NULL-pointer dereference with DEBUG enabled

We are actually passing the gc pointer to chip_dbg() so we have to
srcu_dereference() it.

Fixes: 8574b5b4 ("gpio: cdev: use correct pointer accessors with SRCU")
Reported-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/lkml/179caa10-5f86-4707-8bb0-fe1b316326d6@samsung.com/Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tested-by: default avatarMarek Szyprowski <m.szyprowski@samsung.com>
parent 8ff0d55b
......@@ -2795,8 +2795,8 @@ int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
return ret;
guard(srcu)(&gdev->srcu);
if (!rcu_access_pointer(gdev->chip))
gc = srcu_dereference(gdev->chip, &gdev->srcu);
if (!gc)
return -ENODEV;
chip_dbg(gc, "added GPIO chardev (%d:%d)\n", MAJOR(devt), gdev->id);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment