Commit 9205be7f authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab Committed by Greg Kroah-Hartman

cx23885-dvb: move initialization of a8293_pdata

commit f0b0faff upstream.

Smatch complains about where the au8293_data is placed:

drivers/media/pci/cx23885/cx23885-dvb.c:2174 dvb_register() info: 'a8293_pdata' is not actually initialized (unreached code).

It is not actually expected to have such initialization at

switch {
	foo = bar;

	case:
...
}

Not really sure how gcc does that, but this is something that I would
expect that different compilers would do different things.

David Howells checked with the compiler people: it's not really expected to
initialise as expected.

So, move the initialization outside the switch(), making smatch to
shut up one warning.
Acked-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@osg.samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6b59fb52
...@@ -2168,11 +2168,12 @@ static int dvb_register(struct cx23885_tsport *port) ...@@ -2168,11 +2168,12 @@ static int dvb_register(struct cx23885_tsport *port)
} }
port->i2c_client_tuner = client_tuner; port->i2c_client_tuner = client_tuner;
break; break;
case CX23885_BOARD_HAUPPAUGE_HVR5525: case CX23885_BOARD_HAUPPAUGE_HVR5525: {
switch (port->nr) {
struct m88rs6000t_config m88rs6000t_config; struct m88rs6000t_config m88rs6000t_config;
struct a8293_platform_data a8293_pdata = {}; struct a8293_platform_data a8293_pdata = {};
switch (port->nr) {
/* port b - satellite */ /* port b - satellite */
case 1: case 1:
/* attach frontend */ /* attach frontend */
...@@ -2267,6 +2268,7 @@ static int dvb_register(struct cx23885_tsport *port) ...@@ -2267,6 +2268,7 @@ static int dvb_register(struct cx23885_tsport *port)
break; break;
} }
break; break;
}
default: default:
printk(KERN_INFO "%s: The frontend of your DVB/ATSC card " printk(KERN_INFO "%s: The frontend of your DVB/ATSC card "
" isn't supported yet\n", " isn't supported yet\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment