Commit 9291f090 authored by Florian Westphal's avatar Florian Westphal Committed by Pablo Neira Ayuso

netfilter: ecache: remove another indent level

... by changing:

if (unlikely(ret < 0 || missed)) {
	if (ret < 0) {
to
if (likely(ret >= 0 && !missed))
	goto out;

if (ret < 0) {

After this nf_conntrack_eventmask_report and nf_ct_deliver_cached_events
look pretty much the same, next patch moves common code to a helper.

This patch has no effect on generated code.
Signed-off-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 478374a3
...@@ -165,25 +165,27 @@ int nf_conntrack_eventmask_report(unsigned int eventmask, struct nf_conn *ct, ...@@ -165,25 +165,27 @@ int nf_conntrack_eventmask_report(unsigned int eventmask, struct nf_conn *ct,
goto out_unlock; goto out_unlock;
ret = notify->fcn(eventmask | missed, &item); ret = notify->fcn(eventmask | missed, &item);
if (unlikely(ret < 0 || missed)) { if (likely(ret >= 0 && !missed))
spin_lock_bh(&ct->lock); goto out_unlock;
if (ret < 0) {
/* This is a destroy event that has been spin_lock_bh(&ct->lock);
* triggered by a process, we store the PORTID if (ret < 0) {
* to include it in the retransmission. /* This is a destroy event that has been
*/ * triggered by a process, we store the PORTID
if (eventmask & (1 << IPCT_DESTROY)) { * to include it in the retransmission.
if (e->portid == 0 && portid != 0) */
e->portid = portid; if (eventmask & (1 << IPCT_DESTROY)) {
e->state = NFCT_ECACHE_DESTROY_FAIL; if (e->portid == 0 && portid != 0)
} else { e->portid = portid;
e->missed |= eventmask; e->state = NFCT_ECACHE_DESTROY_FAIL;
}
} else { } else {
e->missed &= ~missed; e->missed |= eventmask;
} }
spin_unlock_bh(&ct->lock); } else {
e->missed &= ~missed;
} }
spin_unlock_bh(&ct->lock);
out_unlock: out_unlock:
rcu_read_unlock(); rcu_read_unlock();
return ret; return ret;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment