Commit 92f45ebe authored by Marek Vasut's avatar Marek Vasut Committed by Linus Walleij

gpio: pca953x: Fix AI overflow on PCAL6524

The PCAL_PINCTRL_MASK is too large. The extended register block on
PCAL6524, which is the largest chip with this block, has the block
limited to address range 0x40..0x7f. This is because the bit 7 in
the command register is used for the Address Increment functionality.

Trim the mask to 0x60 to match the datasheet and to prevent accidental
overwrite of the AI bit.
Signed-off-by: default avatarMarek Vasut <marek.vasut+renesas@gmail.com>
Reviewed-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 873d1e8e
...@@ -58,7 +58,7 @@ ...@@ -58,7 +58,7 @@
#define PCA_GPIO_MASK 0x00FF #define PCA_GPIO_MASK 0x00FF
#define PCAL_GPIO_MASK 0x1f #define PCAL_GPIO_MASK 0x1f
#define PCAL_PINCTRL_MASK 0xe0 #define PCAL_PINCTRL_MASK 0x60
#define PCA_INT 0x0100 #define PCA_INT 0x0100
#define PCA_PCAL 0x0200 #define PCA_PCAL 0x0200
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment