Commit 95c06313 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds

[PATCH] Fix thinkos in #if -> #ifdef conversions

From: Tom Rini <trini@kernel.crashing.org>

When I changed some '#if FOO' tests to '#ifdef FOO' I forgot to make sure
that nothing was doing #define FOO 0.  So after auditing all of the changes
I made, the following is needed:
parent f6364f27
...@@ -32,6 +32,7 @@ ...@@ -32,6 +32,7 @@
#include <linux/config.h> #include <linux/config.h>
#include <linux/module.h> #include <linux/module.h>
#include <linux/kernel.h>
#include <linux/errno.h> #include <linux/errno.h>
#include <linux/signal.h> #include <linux/signal.h>
#include <linux/sched.h> #include <linux/sched.h>
...@@ -190,10 +191,6 @@ ...@@ -190,10 +191,6 @@
#define FALSE 0 #define FALSE 0
#endif #endif
#define DEBUG 0
/* /*
* Things needed by tty driver * Things needed by tty driver
*/ */
...@@ -763,9 +760,7 @@ static void siccuart_change_speed(struct SICC_info *info, struct termios *old_te ...@@ -763,9 +760,7 @@ static void siccuart_change_speed(struct SICC_info *info, struct termios *old_te
cflag = info->tty->termios->c_cflag; cflag = info->tty->termios->c_cflag;
#ifdef DEBUG pr_debug("siccuart_set_cflag(0x%x) called\n", cflag);
printk("siccuart_set_cflag(0x%x) called\n", cflag);
#endif
/* byte size and parity */ /* byte size and parity */
switch (cflag & CSIZE) { switch (cflag & CSIZE) {
case CS7: lcr_h = _LCR_PE_DISABLE | _LCR_DB_7_BITS | _LCR_SB_1_BIT; bits = 9; break; case CS7: lcr_h = _LCR_PE_DISABLE | _LCR_DB_7_BITS | _LCR_SB_1_BIT; bits = 9; break;
...@@ -1027,9 +1022,7 @@ static void siccuart_flush_buffer(struct tty_struct *tty) ...@@ -1027,9 +1022,7 @@ static void siccuart_flush_buffer(struct tty_struct *tty)
struct SICC_info *info = tty->driver_data; struct SICC_info *info = tty->driver_data;
unsigned long flags; unsigned long flags;
#ifdef DEBUG pr_debug("siccuart_flush_buffer(%d) called\n", tty->index);
printk("siccuart_flush_buffer(%d) called\n", tty->index);
#endif
save_flags(flags); cli(); save_flags(flags); cli();
info->xmit.head = info->xmit.tail = 0; info->xmit.head = info->xmit.tail = 0;
restore_flags(flags); restore_flags(flags);
...@@ -1433,9 +1426,7 @@ static void siccuart_close(struct tty_struct *tty, struct file *filp) ...@@ -1433,9 +1426,7 @@ static void siccuart_close(struct tty_struct *tty, struct file *filp)
state = info->state; state = info->state;
#ifdef DEBUG //pr_debug("siccuart_close() called\n");
//printk("siccuart_close() called\n");
#endif
save_flags(flags); cli(); save_flags(flags); cli();
...@@ -1544,11 +1535,9 @@ static void siccuart_wait_until_sent(struct tty_struct *tty, int timeout) ...@@ -1544,11 +1535,9 @@ static void siccuart_wait_until_sent(struct tty_struct *tty, int timeout)
timeout = 2 * info->timeout; timeout = 2 * info->timeout;
expire = jiffies + timeout; expire = jiffies + timeout;
#ifdef DEBUG pr_debug("siccuart_wait_until_sent(%d), jiff=%lu, expire=%lu char_time=%lu...\n",
printk("siccuart_wait_until_sent(%d), jiff=%lu, expire=%lu char_time=%lu...\n",
tty->index, jiffies, tty->index, jiffies,
expire, char_time); expire, char_time);
#endif
while ((readb(info->port->uart_base + BL_SICC_LSR) & _LSR_TX_ALL) != _LSR_TX_ALL) { while ((readb(info->port->uart_base + BL_SICC_LSR) & _LSR_TX_ALL) != _LSR_TX_ALL) {
set_current_state(TASK_INTERRUPTIBLE); set_current_state(TASK_INTERRUPTIBLE);
schedule_timeout(char_time); schedule_timeout(char_time);
...@@ -1831,9 +1820,8 @@ static int siccuart_console_read(struct console *co, const char *s, u_int count) ...@@ -1831,9 +1820,8 @@ static int siccuart_console_read(struct console *co, const char *s, u_int count)
unsigned int status; unsigned int status;
char *w; char *w;
int c; int c;
#ifdef DEBUG
printk("siccuart_console_read() called\n"); pr_debug("siccuart_console_read() called\n");
#endif
c = 0; c = 0;
w = s; w = s;
......
...@@ -33,7 +33,7 @@ ...@@ -33,7 +33,7 @@
#include <asm/pgtable.h> #include <asm/pgtable.h>
#include <asm/cacheflush.h> #include <asm/cacheflush.h>
#define DEBUG_SIG 0 #undef DEBUG_SIG
#define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP))) #define _BLOCKABLE (~(sigmask(SIGKILL) | sigmask(SIGSTOP)))
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment