Commit 95f18be2 authored by Mauro Carvalho Chehab's avatar Mauro Carvalho Chehab

[media] gspca: Fix a warning for using len before filling it

The check for status errors is now before the check for len. That's
ok. However, the error printk's for the status error prints the URB
length. This generates this error:

drivers/media/video/gspca/gspca.c: In function ‘fill_frame’:
drivers/media/video/gspca/gspca.c:305:9: warning: ‘len’ may be used uninitialized in this function

The fix is as simple as moving the len init to happen before the checks.

Cc: Jean-François Moine <moinejf@free.fr>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 2e94b53c
...@@ -318,6 +318,7 @@ static void fill_frame(struct gspca_dev *gspca_dev, ...@@ -318,6 +318,7 @@ static void fill_frame(struct gspca_dev *gspca_dev,
} }
pkt_scan = gspca_dev->sd_desc->pkt_scan; pkt_scan = gspca_dev->sd_desc->pkt_scan;
for (i = 0; i < urb->number_of_packets; i++) { for (i = 0; i < urb->number_of_packets; i++) {
len = urb->iso_frame_desc[i].actual_length;
/* check the packet status and length */ /* check the packet status and length */
st = urb->iso_frame_desc[i].status; st = urb->iso_frame_desc[i].status;
...@@ -327,7 +328,6 @@ static void fill_frame(struct gspca_dev *gspca_dev, ...@@ -327,7 +328,6 @@ static void fill_frame(struct gspca_dev *gspca_dev,
gspca_dev->last_packet_type = DISCARD_PACKET; gspca_dev->last_packet_type = DISCARD_PACKET;
continue; continue;
} }
len = urb->iso_frame_desc[i].actual_length;
if (len == 0) { if (len == 0) {
if (gspca_dev->empty_packet == 0) if (gspca_dev->empty_packet == 0)
gspca_dev->empty_packet = 1; gspca_dev->empty_packet = 1;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment