Commit 960cf811 authored by Devendra Naga's avatar Devendra Naga Committed by Greg Kroah-Hartman

staging: vt6655: vt6655_init_info function must be void type

this is because it doesn't fail anywhere and returning a value
from it will be completely unnecesary.
Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cfd1fc1f
...@@ -290,7 +290,7 @@ DEFINE_PCI_DEVICE_TABLE(vt6655_pci_id_table) = { ...@@ -290,7 +290,7 @@ DEFINE_PCI_DEVICE_TABLE(vt6655_pci_id_table) = {
static int vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent); static int vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent);
static bool vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, PCHIP_INFO); static void vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, PCHIP_INFO);
static void device_free_info(PSDevice pDevice); static void device_free_info(PSDevice pDevice);
static bool device_get_pci_info(PSDevice, struct pci_dev* pcid); static bool device_get_pci_info(PSDevice, struct pci_dev* pcid);
static void device_print_info(PSDevice pDevice); static void device_print_info(PSDevice pDevice);
...@@ -935,9 +935,7 @@ vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent) ...@@ -935,9 +935,7 @@ vt6655_probe(struct pci_dev *pcid, const struct pci_device_id *ent)
bFirst=false; bFirst=false;
} }
if (!vt6655_init_info(pcid, &pDevice, pChip_info)) { vt6655_init_info(pcid, &pDevice, pChip_info);
return -ENOMEM;
}
pDevice->dev = dev; pDevice->dev = dev;
pDevice->next_module = root_device_dev; pDevice->next_module = root_device_dev;
root_device_dev = dev; root_device_dev = dev;
...@@ -1101,7 +1099,7 @@ static void device_print_info(PSDevice pDevice) ...@@ -1101,7 +1099,7 @@ static void device_print_info(PSDevice pDevice)
} }
static bool __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, static void __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice,
PCHIP_INFO pChip_info) { PCHIP_INFO pChip_info) {
PSDevice p; PSDevice p;
...@@ -1125,8 +1123,6 @@ static bool __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice, ...@@ -1125,8 +1123,6 @@ static bool __devinit vt6655_init_info(struct pci_dev* pcid, PSDevice* ppDevice,
(*ppDevice)->multicast_limit =32; (*ppDevice)->multicast_limit =32;
spin_lock_init(&((*ppDevice)->lock)); spin_lock_init(&((*ppDevice)->lock));
return true;
} }
static bool device_get_pci_info(PSDevice pDevice, struct pci_dev* pcid) { static bool device_get_pci_info(PSDevice pDevice, struct pci_dev* pcid) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment