Commit 962411b0 authored by Wenwen Wang's avatar Wenwen Wang Committed by Vinod Koul

dmaengine: ti: omap-dma: Add cleanup in omap_dma_probe()

If devm_request_irq() fails to disable all interrupts, no cleanup is
performed before retuning the error. To fix this issue, invoke
omap_dma_free() to do the cleanup.
Signed-off-by: default avatarWenwen Wang <wenwen@cs.uga.edu>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/1565938570-7528-1-git-send-email-wenwen@cs.uga.eduSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 2c231c0c
...@@ -1540,8 +1540,10 @@ static int omap_dma_probe(struct platform_device *pdev) ...@@ -1540,8 +1540,10 @@ static int omap_dma_probe(struct platform_device *pdev)
rc = devm_request_irq(&pdev->dev, irq, omap_dma_irq, rc = devm_request_irq(&pdev->dev, irq, omap_dma_irq,
IRQF_SHARED, "omap-dma-engine", od); IRQF_SHARED, "omap-dma-engine", od);
if (rc) if (rc) {
omap_dma_free(od);
return rc; return rc;
}
} }
if (omap_dma_glbl_read(od, CAPS_0) & CAPS_0_SUPPORT_LL123) if (omap_dma_glbl_read(od, CAPS_0) & CAPS_0_SUPPORT_LL123)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment