Commit 9624bafa authored by Lukas Wunner's avatar Lukas Wunner Committed by David S. Miller

net: ks8851: Set initial carrier state to down

The ks8851 chip's initial carrier state is down. A Link Change Interrupt
is signaled once interrupts are enabled if the carrier is up.

The ks8851 driver has it backwards by assuming that the initial carrier
state is up. The state is therefore misrepresented if the interface is
opened with no cable attached. Fix it.

The Link Change interrupt is sometimes not signaled unless the P1MBSR
register (which contains the Link Status bit) is read on ->ndo_open().
This might be a hardware erratum. Read the register by calling
mii_check_link(), which has the desirable side effect of setting the
carrier state to down if the cable was detached while the interface was
closed.
Signed-off-by: default avatarLukas Wunner <lukas@wunner.de>
Cc: Frank Pavlic <f.pavlic@kunbus.de>
Cc: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: Tristram Ha <Tristram.Ha@microchip.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d268f315
...@@ -858,6 +858,7 @@ static int ks8851_net_open(struct net_device *dev) ...@@ -858,6 +858,7 @@ static int ks8851_net_open(struct net_device *dev)
netif_dbg(ks, ifup, ks->netdev, "network device up\n"); netif_dbg(ks, ifup, ks->netdev, "network device up\n");
mutex_unlock(&ks->lock); mutex_unlock(&ks->lock);
mii_check_link(&ks->mii);
return 0; return 0;
} }
...@@ -1519,6 +1520,7 @@ static int ks8851_probe(struct spi_device *spi) ...@@ -1519,6 +1520,7 @@ static int ks8851_probe(struct spi_device *spi)
spi_set_drvdata(spi, ks); spi_set_drvdata(spi, ks);
netif_carrier_off(ks->netdev);
ndev->if_port = IF_PORT_100BASET; ndev->if_port = IF_PORT_100BASET;
ndev->netdev_ops = &ks8851_netdev_ops; ndev->netdev_ops = &ks8851_netdev_ops;
ndev->irq = spi->irq; ndev->irq = spi->irq;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment