Commit 97489c28 authored by Brian Norris's avatar Brian Norris Committed by Kalle Valo

mwifiex: pcie: stop checking for NULL adapter->card

It should never be NULL here, and to think otherwise makes things
confusing.
Signed-off-by: default avatarBrian Norris <briannorris@chromium.org>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent e98fb11f
...@@ -3015,31 +3015,28 @@ static int mwifiex_register_dev(struct mwifiex_adapter *adapter) ...@@ -3015,31 +3015,28 @@ static int mwifiex_register_dev(struct mwifiex_adapter *adapter)
static void mwifiex_unregister_dev(struct mwifiex_adapter *adapter) static void mwifiex_unregister_dev(struct mwifiex_adapter *adapter)
{ {
struct pcie_service_card *card = adapter->card; struct pcie_service_card *card = adapter->card;
struct pci_dev *pdev; struct pci_dev *pdev = card->dev;
int i; int i;
if (card) { if (card->msix_enable) {
pdev = card->dev; for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++)
if (card->msix_enable) { synchronize_irq(card->msix_entries[i].vector);
for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++)
synchronize_irq(card->msix_entries[i].vector);
for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++) for (i = 0; i < MWIFIEX_NUM_MSIX_VECTORS; i++)
free_irq(card->msix_entries[i].vector, free_irq(card->msix_entries[i].vector,
&card->msix_ctx[i]); &card->msix_ctx[i]);
card->msix_enable = 0; card->msix_enable = 0;
pci_disable_msix(pdev); pci_disable_msix(pdev);
} else { } else {
mwifiex_dbg(adapter, INFO, mwifiex_dbg(adapter, INFO,
"%s(): calling free_irq()\n", __func__); "%s(): calling free_irq()\n", __func__);
free_irq(card->dev->irq, &card->share_irq_ctx); free_irq(card->dev->irq, &card->share_irq_ctx);
if (card->msi_enable) if (card->msi_enable)
pci_disable_msi(pdev); pci_disable_msi(pdev);
}
card->adapter = NULL;
} }
card->adapter = NULL;
} }
/* This function initializes the PCI-E host memory space, WCB rings, etc. /* This function initializes the PCI-E host memory space, WCB rings, etc.
...@@ -3122,18 +3119,14 @@ static void mwifiex_pcie_down_dev(struct mwifiex_adapter *adapter) ...@@ -3122,18 +3119,14 @@ static void mwifiex_pcie_down_dev(struct mwifiex_adapter *adapter)
adapter->seq_num = 0; adapter->seq_num = 0;
adapter->tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K; adapter->tx_buf_size = MWIFIEX_TX_DATA_BUF_SIZE_4K;
if (card) { if (reg->sleep_cookie)
if (reg->sleep_cookie) mwifiex_pcie_delete_sleep_cookie_buf(adapter);
mwifiex_pcie_delete_sleep_cookie_buf(adapter);
mwifiex_pcie_delete_cmdrsp_buf(adapter);
mwifiex_pcie_delete_evtbd_ring(adapter);
mwifiex_pcie_delete_rxbd_ring(adapter);
mwifiex_pcie_delete_txbd_ring(adapter);
card->cmdrsp_buf = NULL;
}
return; mwifiex_pcie_delete_cmdrsp_buf(adapter);
mwifiex_pcie_delete_evtbd_ring(adapter);
mwifiex_pcie_delete_rxbd_ring(adapter);
mwifiex_pcie_delete_txbd_ring(adapter);
card->cmdrsp_buf = NULL;
} }
static struct mwifiex_if_ops pcie_ops = { static struct mwifiex_if_ops pcie_ops = {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment